Skip to content

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Apr 10, 2025

Supersedes #1515 and fixes #1001

Proposed changes:

  • Stores the Activity in the Comment-Meta, because we have to get sure, that the comment will be approved or not before announcing it
  • Hook into approve process, to late federate the Announce

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Apply this change to a WP test site that's accessible online.
  • Comment on a post from a fediverse instance of your choice.
  • Check the Outbox and make sure it created an Announce activity.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Incoming interactions create an Announce activity so other instances get notified about it.

@pfefferle pfefferle self-assigned this Apr 10, 2025
@pfefferle pfefferle requested a review from obenland April 10, 2025 11:14
@pfefferle pfefferle marked this pull request as draft April 10, 2025 13:54
Replaces incorrect 'Comment_Utils' with 'Comment_Util' in schedule_comment_delete_activity to ensure the correct utility class is used for checking if a comment was sent.
Replaces all instances of 'Comment_Util' with 'Comment_Utils' in class-comment.php to match the correct class name and prevent potential errors.
Adds a default value for the 'type' field in handle_undo to prevent undefined index errors. Updates object attribute validation to only check required fields if 'object' is an array, allowing string/URI objects. Adds a test case to ensure URI objects pass validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments left by mastodon do not get pushed to lemmy
3 participants